docs: update contributing guide #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
approved these changes
Oct 12, 2022
|
Done! Updated based on your review. |
cdrage
force-pushed
the
contributing-guide
branch
from
be64081
to
6c06acc
Compare
|
Nice enhancements @cdrage ! |
### What does this PR do? Updates the contributing guide with new styling as well as reorganizing some sections. I have also added some tips such as running `yarn test` as well as the linter and formatter. ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> N/A ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> N/A ### How to test this PR? <!-- Please explain steps to reproduce --> See docs :) Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
force-pushed
the
contributing-guide
branch
from
6c06acc
to
be63ebc
Compare
rdwz
pushed a commit
to rdwz/podman-desktop
that referenced
this pull request
Oct 15, 2022
* docs: update contributing guide ### What does this PR do? Updates the contributing guide with new styling as well as reorganizing some sections. I have also added some tips such as running `yarn test` as well as the linter and formatter. ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> N/A ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> N/A ### How to test this PR? <!-- Please explain steps to reproduce --> See docs :) Signed-off-by: Charlie Drage <charlie@charliedrage.com> * docs: update based on review Signed-off-by: Charlie Drage <charlie@charliedrage.com> Signed-off-by: Charlie Drage <charlie@charliedrage.com> Signed-off-by: Rychardt Rothwërkz <redwerkz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: update contributing guide
What does this PR do?
Updates the contributing guide with new styling as well as reorganizing
some sections.
I have also added some tips such as running
yarn testas well as thelinter and formatter.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A
How to test this PR?
See docs :)
Signed-off-by: Charlie Drage charlie@charliedrage.com