-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ability to edit kube yaml #5937
Conversation
485726d
to
b3648e4
Compare
b3648e4
to
f333a91
Compare
linking to #519 |
dfc26d0
to
d8cdf62
Compare
Notes! This is a very simple implementation of applying the Kubernetes YAML to the cluster / being able to edit. However there are NO tests for MonacoEditor. There was already no tests for MonacoEditor, as well as the fact that monaco-editor is dynamically important making it difficult to test see [1] and [2]. There have been tests added however for the Kubernetes client. I have also opened up #6001 in order to create an e2e test for editing YAML which has been assigned to @odockal |
d8cdf62
to
d9a2884
Compare
Tested editing recplicas, image of pod, rollingUpdate params, works great! |
c6dfe45
to
55fa26f
Compare
@feloy You're right! That'd be beneficial to have some form of explanation of what's going on when pressing apply. I couldn't find a good way to add this as a description on the same page (no space as the editor fills it entirely), but instead I've added a tooltip. Screen.Recording.2024-02-22.at.11.00.29.AM.mov |
55fa26f
to
07e2ebb
Compare
Tested. This is super cool, and really handy to make quick edits. 🚀 Some nits:
In the future I'd also like an option to hide/remove things like status/managedFields/last-applied-configuration to make it easier to see and edit just the configuration of a resource - probably a good follow-up question for UX call. |
### What does this PR do? * Adds the ability to edit kube yaml with two buttons, "revert" and "apply" * Renames Kube section to "Edit" ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes containers#5662 ### How to test this PR? 1. Go to Kube tab 2. Edit a YAML (Deployment only right now) 3. Click on apply / revert buttons. <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
- should be kube not edit for tab - apply disabled until you type something - same for revert Signed-off-by: Charlie Drage <charlie@charliedrage.com>
d67fec9
to
400837b
Compare
Ready for another review! I've implemented the following changes:
Issue for managed fields is here: #5936 Issue for transparent background for buttons is here: #6117 Ready for another test / review @feloy @deboer-tim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, very useful feature, thanks
Merging as it's been now tested multiple times and reviewed by @deboer-tim @feloy and @lstocchi Thank you for being patient and doing lots of testing on this! |
feat: ability to edit kube yaml
What does this PR do?
"apply"
Screenshot / video of UI
Screen.Recording.2024-02-09.at.4.46.08.PM.mov
What issues does this PR fix or reference?
Closes #5662
How to test this PR?
Signed-off-by: Charlie Drage charlie@charliedrage.com