feat: publish colors to the style of the app #5962
Conversation
benoitf
requested review from
jeffmaury and
feloy
and removed request for
a team
There was a problem hiding this comment.
FontAwesome uses --fa- prefix, Tailwind uses --tw-. Could we just use --pd-?
The mix of both - and camelcase (i.e. --a-b-CandD) is a little jarring to me, and most others seem to use only -. If this is the main way people will interact I'm wondering if we should switch, or maybe even auto-convert when we expose as vars?
|
yes I was thinking the same after I started the implementation. (short name rather than podman-desktop) About color names I think they need to have the same name with or without the prefix so if we want |
|
and we might expose the color palette colors as well but it's surely a separate PR |
benoitf
force-pushed
the
colors-as-css
branch
from
831ee7d
to
fb1e170
Compare
|
updated the PR with new shorter color scheme |
it's publishing the colors in CSS with variables so components can use the definition of these colors related to containers#5914 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
colors-as-css
branch
from
fb1e170
to
91e3c03
Compare
|
@deboer-tim are we good now ? |
What does this PR do?
it's publishing the colors in CSS with variables
so components can use the definition of these colors
register each color defined under the name
--pd-<name-of-the-color>depends on:
Screenshot / video of UI
What issues does this PR fix or reference?
related to #5914
How to test this PR?
unit tests provided