chore: use checkbox component in deploy to kube #6030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using standard checkboxes in the Deploy to Kubernetes form instead of our styled Checkbox component. This just switches them and updates the test to be more consistent. Wrapper <div>s added because Checkbox (a composite) doesn't work as well w/o a layout, but this also fixes the problem where text was wrapping below the checkbox when it shouldn't. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
axel7083 and
lstocchi
and removed request for
a team
deboer-tim
changed the title
benoitf
approved these changes
Feb 15, 2024
cdrage
approved these changes
Feb 15, 2024
benoitf
reviewed
Feb 15, 2024
Signed-off-by: Tim deBoer <git@tdeboer.ca>
Signed-off-by: Tim deBoer <git@tdeboer.ca>
Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We are using standard checkboxes in the Deploy to Kubernetes form instead of our styled Checkbox component. This just switches them and updates the test to be more consistent.
Wrapper
Screenshot / video of UI
Before:
After:
What issues does this PR fix or reference?
N/A
How to test this PR?
Unit tests updated, just check UI.