chore: use components in quickpick #6057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quickpick was using an unstyled checkbox and button, this just switches it to use the Checkbox and Button components. Checkbox required the ability to set the class. I also replaced two violets with purple to match our normal selection color - although it'll probably be replaced by variables soon, this will make it match in the meantime and easier to find. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
dgolovin and
feloy
and removed request for
a team
cdrage
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The quickpick was using an unstyled checkbox and button, this just switches it to use the Checkbox and Button components.
Checkbox required the ability to set the class. I also replaced two violets with purple to match our normal selection color - although it'll probably be replaced by variables soon, this will make it match in the meantime and easier to find.
Screenshot / video of UI
Before:
After:
What issues does this PR fix or reference?
N/A
How to test this PR?
Open a multi-select quick pick.