New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve Podman-Desktop update alert #6068
feat: improve Podman-Desktop update alert #6068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a refactoring and a new addition in the same PR so it's hard to track what is new, what is refactoring
I think having refactored first (extract to a separate class first) and then adding feature would have helped the review
I made a didicated PR for the refactor in #6159 - keeping this in draft for now |
2e18e23
to
e0e2d3b
Compare
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
d1f3e79
to
c248a13
Compare
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when starting Podman Desktop I have the message
while if I click on the version icon I have
I like the fact to have the version number of the new version to be displayed
could we have the same sentence ?
about the buttons, I think I see too many 'Update' choice
I'm not sure about the 'Update Later' and 'Update never' (I think the never is looking odd as I can still click on the version to update)
should it be around 'Skip' for 'Update Later' and 'notifications' (or any other wording)
About the notify later, should it still prompt on every startup or should it be in case of a new version is released.
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it way better now 🎉
it's not related to this PR but maybe we should change our wording when there is a new version as the last version that we see at the end of the sentence is the current version
so reading it quickly I have the feeling that it's asking to update to the version number that we have
If others share the same concern, we could do follow-up, if I'm the only one then we can just ignore :-)
before merging, you'll need to update the body of the PR with accurate screenshot/video |
What does this PR do?
According to #5754.
When an update is available
A new preference section called
Update
has a propertyreminer
with two valuestartup
ornever
.Screenshot / video of UI
starting
podman-desktop
Clicking on status bar item when update available (status bar item)
What issues does this PR fix or reference?
Fixes #5754
How to test this PR?
Testing manually
(1) change the version to
1.6.5
in thepackage.json
at the root(2) run
yarn compile:current
(3) go to
dist
folder and start the portable executable(Thx to @benoitf for this method)