Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh onboarding item when context value gets updated (#4597) #6173

Merged
merged 2 commits into from Feb 28, 2024

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Feb 27, 2024

What does this PR do?

it allows an onboarding item to be refreshed when the context value gets updated

Screenshot / video of UI

onboarding_refresh

What issues does this PR fix or reference?

it resolves #4597

How to test this PR?

  1. have the virtualization platform disabled
  2. run podman onboarding and see the requirements step fails
  3. enable virtualization platform
  4. click on rerun requirements check
  5. the virtual platform check should be successful
  • Tests are covering the bug fix or the new feature

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise LGTM

Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: Luca Stocchi <49404737+lstocchi@users.noreply.github.com>
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Compose and Podman. Going through code and it also LGTM.

@cdrage cdrage merged commit 8be8fa3 into containers:main Feb 28, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.8.0 milestone Feb 28, 2024
cdrage added a commit to cdrage/podman-desktop that referenced this pull request Feb 29, 2024
…ers#4597) (containers#6173)

* fix: refresh onboarding item when context value gets updated (containers#4597)

Signed-off-by: lstocchi <lstocchi@redhat.com>

* Update packages/renderer/src/lib/onboarding/OnboardingItem.svelte

Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: Luca Stocchi <49404737+lstocchi@users.noreply.github.com>

---------

Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: Luca Stocchi <49404737+lstocchi@users.noreply.github.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rerunning requirements check for Onboarding Podman workflow does not reflect actual state
5 participants