New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refresh onboarding item when context value gets updated (#4597) #6173
Conversation
…ers#4597) Signed-off-by: lstocchi <lstocchi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codewise LGTM
Co-authored-by: Florent BENOIT <fbenoit@redhat.com> Signed-off-by: Luca Stocchi <49404737+lstocchi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Compose and Podman. Going through code and it also LGTM.
…ers#4597) (containers#6173) * fix: refresh onboarding item when context value gets updated (containers#4597) Signed-off-by: lstocchi <lstocchi@redhat.com> * Update packages/renderer/src/lib/onboarding/OnboardingItem.svelte Co-authored-by: Florent BENOIT <fbenoit@redhat.com> Signed-off-by: Luca Stocchi <49404737+lstocchi@users.noreply.github.com> --------- Signed-off-by: lstocchi <lstocchi@redhat.com> Signed-off-by: Luca Stocchi <49404737+lstocchi@users.noreply.github.com> Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
What does this PR do?
it allows an onboarding item to be refreshed when the context value gets updated
Screenshot / video of UI
What issues does this PR fix or reference?
it resolves #4597
How to test this PR?