chore: bump dockerode/ssh2 to their latest version #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we had some issues so we were using an old version of ssh2 but now, this is working disable also electron builder rebuilding of native modules as it's failing on optional dependency of ssh2 which is cpu-features. So while it's an optional dependency, developers are seeing a huge compilation error everytime. By disabling the rebuilding, we don't try to compile the optional dependency, then no error is displayed Change-Id: I6ae3537e8b04211f64461c2e039ec1b81f92ff0d Signed-off-by: Florent Benoit <fbenoit@redhat.com>
cdrage
approved these changes
Oct 17, 2022
vzhukovs
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before we had some issues so we were using an old version of ssh2 but now, this is working
disable also electron builder rebuilding of native modules as it's failing on optional dependency of ssh2 which is cpu-features.
So while it's an optional dependency, developers are seeing a huge compilation error everytime. By disabling the rebuilding, we don't try to compile the optional dependency, then no error is displayed
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A
How to test this PR?
Connection to container engines should work
Change-Id: I6ae3537e8b04211f64461c2e039ec1b81f92ff0d
Signed-off-by: Florent Benoit fbenoit@redhat.com