Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send kubernetes-context-update event when kubeconfig file created/deleted #6307

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: send kubernetes-context-update event when kubeconfig file created/deleted #6307

merged 1 commit into from
Mar 7, 2024

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Mar 7, 2024 •
edited
Loading

Signed-off-by: Philippe Martin phmartin@redhat.com

What does this PR do?

send kubernetes-context-update event when kubeconfig file
is created or deleted.

What issues does this PR fix or reference?

Fixes #6305

How to test this PR?

  1. Rename your ~/.kube/config to another name
  2. Start Podman Desktop, create a minikube or kind cluster
  3. Go to the Kubernetes Contexts page, a new context should appear for the new cluster
  4. Delete the created ~/.kube/config
  5. Go to the Kubernetes Contexts page, the context should have disappeared
  6. (Restore you original ~/.kube/config file)
  • Tests are covering the bug fix or the new feature

@feloy
fix: send kubernetes-context-update event when kubeconfig file create…
ac167b6 
…d/deleted

Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy requested review from benoitf and a team as code owners March 7, 2024 14:07
@feloy feloy requested review from dgolovin, axel7083 and cdrage and removed request for a team March 7, 2024 14:07
@feloy feloy merged commit 5e2f48d into containers:main Mar 7, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.8.0 milestone Mar 7, 2024
@feloy feloy mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@deboer-tim deboer-tim deboer-tim approved these changes

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from containers/podman-desktop-reviewers

@axel7083 axel7083 Awaiting requested review from axel7083 axel7083 is a code owner automatically assigned from containers/podman-desktop-reviewers

@cdrage cdrage Awaiting requested review from cdrage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

When a kubeconfig file is created or deleted, it is not reflected in Kubernetes Contexts page
4 participants
@feloy @benoitf @deboer-tim @podman-desktop-bot