fix: add playsinline to avoid full screen #6395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'playing' attribute sets the player to auto-start, but it is starting full screen. Adding 'playsinline' to every react player should ensure that it doesn't go full screen on phones. Fixes containers#6335. Signed-off-by: Tim deBoer <git@tdeboer.ca>
|
My wifi and cell connection atm is incredibly bad, but looks like this change solves the problem by making videos on mobile inline, without any regression to desktop web browsers. Moving to regular review. |
deboer-tim
requested review from
slemeur,
cdrage,
benoitf and
a team
as code owners
benoitf
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The 'playing' attribute sets the player to auto-start, but it is starting full screen. Adding 'playsinline' to every react player should ensure that it doesn't go full screen on phones.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #6335.
How to test this PR?
Browse blogs with videos (e.g. 1.5 release) on a phone and confirm the videos aren't full screen by default.