Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add secrets handling to extensionContext in extension api #6423

Merged
merged 1 commit into from Mar 19, 2024

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Mar 14, 2024

What does this PR do?

expose to extensions secrets storage

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

fixes #6044

How to test this PR?

unit tests added

  • Tests are covering the bug fix or the new feature

@benoitf benoitf requested a review from a team as a code owner March 14, 2024 21:06
@benoitf benoitf requested review from dgolovin and lstocchi and removed request for a team March 14, 2024 21:06
@benoitf benoitf changed the title feat: add extension api to handle secrets feat: add secrets handling to extensionContext in extension api Mar 14, 2024
fixes containers#6044
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
Copy link
Collaborator Author

benoitf commented Mar 15, 2024

PTAL @dgolovin

Copy link
Contributor

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf benoitf merged commit ed20873 into containers:main Mar 19, 2024
10 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.9.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a secret store
4 participants