Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use expected component in the tests #6424

Merged
merged 1 commit into from Mar 15, 2024
Merged

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Mar 14, 2024

What does this PR do?

when working on a change in ExtensionStatus I noticed that some unrelated tests were breaking
it turns out that the test file is not testing the expected component
it is testing ExtensionStatus instead of ProviderStatus
fixing the test to match the component that we need to test

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

#6410

How to test this PR?

unit test provided

  • Tests are covering the bug fix or the new feature

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner March 14, 2024 21:17
@benoitf benoitf requested review from cdrage and feloy and removed request for a team March 14, 2024 21:17
@odockal
Copy link
Contributor

odockal commented Mar 15, 2024

@benoitf Nice catch!

@benoitf benoitf merged commit 545658d into containers:main Mar 15, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.9.0 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants