feat: add sign in button for auth providers w/ the only auth session request #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgolovin
requested review from
jeffmaury and
axel7083
and removed request for
a team
|
Component tests have not been implemented yet |
benoitf
reviewed
Mar 18, 2024
packages/renderer/src/lib/preferences/PreferencesAuthenticationProvidersRendering.svelte
Outdated
Show resolved
Hide resolved
packages/renderer/src/lib/preferences/PreferencesAuthenticationProvidersRendering.svelte
Show resolved
Hide resolved
vrothberg
reviewed
Mar 18, 2024
This was referenced Mar 18, 2024
dgolovin
force-pushed
the
i5979-auth-sign-in-button-with-tooltips
branch
from
5a8cc57
to
0b355da
Compare
vrothberg
approved these changes
Mar 19, 2024
…request Signed-off-by: Denis Golovin <dgolovin@redhat.com>
…nProvidersRendering.svelte Co-authored-by: Florent BENOIT <fbenoit@redhat.com> Signed-off-by: Denis Golovin <dgolovin@users.noreply.github.com>
Signed-off-by: Denis Golovin <dgolovin@redhat.com>
benoitf
force-pushed
the
i5979-auth-sign-in-button-with-tooltips
branch
from
0b355da
to
82c82a5
Compare
|
rebased to include the Tooltip changes from main branch |
Out of curiosity: what are these tooltip changes? |
|
@vrothberg #6445 |
|
Ready to merge? |
benoitf
approved these changes
Mar 19, 2024
|
@vrothberg need @axel7083 or @jeffmaury review that were assigned for the review (two +1 from core team for new feat) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR adds logic to auth provider record on Authentication settings page to show
Sign inbutton in case of only one none silent authentication request registered. If there are multiple requests then Drop down menu is component is used to list all request for user selection.Screenshot / video of UI
What issues does this PR fix or reference?
How to test this PR?