New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add generic action to task #6453
Conversation
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
I'm finding it hard to follow the comments and changes afterwards, but if this went from a 'folder URI' to a function -which could do anything - why keep the property named 'folder'? Wouldn't it make sense to allow things like 'open file' or 'open logs' as well? Maybe even 'open browser'? Those seem just as likely for other tasks, and would only require a label as well. |
It was always a function, the thing discussed was how to pass the info ( as a string or as a Uri) to the backend. |
Yes, I think that's what I'm suggesting. Maybe it is even worth replacing goToTask (not necessarily in this PR...) or allowing more than one. We should keep some consistency in the labels, but this gives any task a simple and generic way to link to relevant things, whether it's a status page, logs, a folder, help, etc. |
Signed-off-by: lstocchi <lstocchi@redhat.com>
@deboer-tim updated 👍 |
Thanks for the change. 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
It adds a new property to a task to implement a custom behavior like show an 'open folder' action.
This will be used with the export container action. When the export is executing/has been executed the user could open the taskmanager, click on the open folder link to open the directory where the container content will be saved
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
it is part of #6355
How to test this PR?