Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experimental flag to install podman v5 #6476

Merged
merged 1 commit into from Mar 24, 2024

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Mar 20, 2024

What does this PR do?

if toggling the flag in preferences, it'll register the 'update to v5.0.0'

depends on this PR

Screenshot / video of UI

image

image

What issues does this PR fix or reference?

fixes #6375

How to test this PR?

you can run Podman Desktop and toggle the flag then you should see "Update to 5.0.0" flag
if you don't see it immediately, refresh the UI of the client or apply #6475 before

  • Tests are covering the bug fix or the new feature

@benoitf benoitf requested a review from a team as a code owner March 20, 2024 12:51
@benoitf benoitf requested review from dgolovin and lstocchi and removed request for a team March 20, 2024 12:51
if toggling the flag in preferences, it'll register the
'update to v5.0.0'

fixes containers#6375

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I have some other issues like i cannot create a podman machine 😓 but it installed podman 5 correctly

Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked for me, and I was able to install Podman 5 (and create/start a machine).

Only nit: "V5" isn't a great name for the property in the UI. Something like 'experimental' would work better, but then wouldn't be a v5 specific property so may not be a better choice.

@benoitf
Copy link
Collaborator Author

benoitf commented Mar 20, 2024

ExperimentalV5 would be better as property name displayed in the UI ?

@vzhukovs
Copy link
Contributor

Maybe V5 -> Experimental Support and get rid of (experimental) in property description? Wdyt?

@benoitf
Copy link
Collaborator Author

benoitf commented Mar 21, 2024

@vzhukovs it displays only the last 'word' so it'll display either V5 or Experimental if we call it foo.experimental.v5 or foo.experimental.v5

@deboer-tim
Copy link
Collaborator

This is why I had an issue open a while ago to be able to supply a 'display name' 😆. V5 or ExperimentalV5 are likely the best we can do and I'm fine with either.

@vzhukovs
Copy link
Contributor

@vzhukovs it displays only the last 'word' so it'll display either V5 or Experimental if we call it foo.experimental.v5 or foo.experimental.v5

Then, V5 sounds better

@cdrage
Copy link
Contributor

cdrage commented Mar 21, 2024

@vzhukovs it displays only the last 'word' so it'll display either V5 or Experimental if we call it foo.experimental.v5 or foo.experimental.v5

Then, V5 sounds better

👍 on just V5

@benoitf
Copy link
Collaborator Author

benoitf commented Mar 21, 2024

ok so it seems the consensus is that I keep as it is

I'll merge tomorrow unless someone will request changes

@benoitf benoitf merged commit ade2a13 into containers:main Mar 24, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.9.0 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should allow to install podman v5 using an experimental flag
6 participants