New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add experimental flag to install podman v5 #6476
Conversation
if toggling the flag in preferences, it'll register the 'update to v5.0.0' fixes containers#6375 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have some other issues like i cannot create a podman machine 😓 but it installed podman 5 correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked for me, and I was able to install Podman 5 (and create/start a machine).
Only nit: "V5" isn't a great name for the property in the UI. Something like 'experimental' would work better, but then wouldn't be a v5 specific property so may not be a better choice.
ExperimentalV5 would be better as property name displayed in the UI ? |
Maybe |
@vzhukovs it displays only the last 'word' so it'll display either |
This is why I had an issue open a while ago to be able to supply a 'display name' 😆. V5 or ExperimentalV5 are likely the best we can do and I'm fine with either. |
Then, V5 sounds better |
👍 on just V5 |
ok so it seems the consensus is that I keep as it is I'll merge tomorrow unless someone will request changes |
What does this PR do?
if toggling the flag in preferences, it'll register the 'update to v5.0.0'
depends on this PR
for better result
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #6375
How to test this PR?
you can run Podman Desktop and toggle the flag then you should see "Update to 5.0.0" flag
if you don't see it immediately, refresh the UI of the client or apply #6475 before