Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ask to wipe all data when migrating from podman v4 to v5 #6539

Merged
merged 2 commits into from Mar 26, 2024

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Mar 26, 2024

What does this PR do?

Also bring a confirmation dialog
it is still an optional step

Screenshot / video of UI

What issues does this PR fix or reference?

fixes #6522

How to test this PR?

  1. install v4.9.3
  2. enable the experimental v5 upgrade flag
  3. click on 'update to 5.0.0

then you should be prompted to wipe all data and confirm it

also unit tests are provided

  • Tests are covering the bug fix or the new feature

@benoitf benoitf requested a review from a team as a code owner March 26, 2024 10:41
@benoitf benoitf requested review from cdrage and lstocchi and removed request for a team March 26, 2024 10:41
@benoitf benoitf changed the title feat: ask to wipe all data when migrating from v4 to v5 feat: ask to wipe all data when migrating from podman v4 to v5 Mar 26, 2024
also bring a confirmation dialog
it is still an optional step

fixes containers#6522

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on win and works fine.
Just a doubt about the messages from a non-native speaker

extensions/podman/src/podman-install.ts Outdated Show resolved Hide resolved
extensions/podman/src/podman-install.ts Outdated Show resolved Hide resolved
…ring a confirmation dialog it is still an optional step

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally I properly have the dialogs. LGTM

@odockal odockal requested a review from a team March 26, 2024 12:13
@benoitf benoitf merged commit 07ae0cf into containers:main Mar 26, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.9.0 milestone Mar 26, 2024
ekidneyrh pushed a commit to ekidneyrh/podman-desktop that referenced this pull request Apr 2, 2024
…iners#6539)

* feat: ask to wipe all data when migrating from v4 to v5
also bring a confirmation dialog
it is still an optional step

fixes containers#6522

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: emma kidney <ekidney@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In case of podman v4 -> v5 update, ask the user to wipe out all data
4 participants