feat: default to podman v5 for new users #6548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
dgolovin and
axel7083
and removed request for
a team
deboer-tim
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Tested, worked for me (also had to delete/rename /opt/podman of course). 👍🏼
Code LGTM but the console output is a bit odd, something like
console.log('Check for podman install folders',
!fs.existsSync(path.resolve(os.homedir(), '.config/containers/podman'),
!fs.existsSync(path.resolve(os.homedir(), '.local/share/containers/podman');
would be more clear to me in the logs.
if you have an existing podman installation, you need to enable a flag but without a previous podman installation you can install v5 fixes containers#6523 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
it was my bad it shouldn't have been committed :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
if you have an existing podman installation, you need to enable a flag but without a previous podman installation you can install v5
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #6523
How to test this PR?
remove all
$HOME/.config/containers/podmanand$HOME/.local/share/containers/podmanit should install v5with something there it should install/update only to v4 without v5 experimental flag
Added unit tests