Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add navigateToAuthentication method to navigation API #6603

Merged

Conversation

dgolovin
Copy link
Contributor

@dgolovin dgolovin commented Apr 2, 2024

What does this PR do?

PR adds async navigateToAuthentication(): Promise<void> to API 'navigation' module to let extensions to navigate user to Authentication Settings page

Screenshot / video of UI

What issues does this PR fix or reference?

Going to be used in Red Hat SSO status item implementation (see redhat-developer/podman-desktop-redhat-account-ext#91)

How to test this PR?

  • Tests are covering the bug fix or the new feature

@dgolovin dgolovin requested review from benoitf and a team as code owners April 2, 2024 22:07
@dgolovin dgolovin requested review from jeffmaury and axel7083 and removed request for a team April 2, 2024 22:07
Signed-off-by: Denis Golovin <dgolovin@redhat.com>
@dgolovin dgolovin force-pushed the navigation-to-authentication-settings-page branch from 9a05b67 to 4758cf9 Compare April 2, 2024 22:08
packages/extension-api/src/extension-api.d.ts Outdated Show resolved Hide resolved
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: Denis Golovin <dgolovin@users.noreply.github.com>
@dgolovin dgolovin merged commit 689b3f8 into containers:main Apr 3, 2024
10 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.9.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants