fix: provide correct return value for the method #6648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and do not try to cast the return value of the method to something else in the client The method contract was invalid but then the client was changing the expected value to match the real value so here just fix the returned value so the client does not need to change the return type fixes containers#6631 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
jeffmaury and
cdrage
and removed request for
a team
deboer-tim
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The method contract was invalid but then the client was changing the expected value to match the real value
so here just fix the returned value so the client does not need to change the return type
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #6631
How to test this PR?
go to pods details view with a non OpenShift cluster, you should no longer see errors in the console