Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): split featured extensions svelte component #6673

Merged

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Apr 5, 2024

What does this PR do?

Move the content of the each block of the FeaturedExtensions.svelte component to a file, to make it standalone, and reusable.

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #6669

How to test this PR?

  • existing unit tests ensure no regression

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested review from benoitf and a team as code owners April 5, 2024 10:24
@axel7083 axel7083 requested review from dgolovin and cdrage and removed request for a team April 5, 2024 10:24
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should take tests inside FeaturedExtensions.spec.ts and make 3 for FeaturedExtension.spec.ts

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083
Copy link
Contributor Author

axel7083 commented Apr 5, 2024

You should take tests inside FeaturedExtensions.spec.ts and make 3 for FeaturedExtension.spec.ts

Done ✅

@axel7083 axel7083 requested a review from benoitf April 5, 2024 11:02
@axel7083 axel7083 merged commit 1abdbfa into containers:main Apr 5, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.10.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split the FeaturedExtensions svelte component to make individual item reusable
3 participants