fix: start a pod instead of trying to start each individual container #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I41ece2faff39b736a5c85f4e675a624df96b3336 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
at the end of creating the pod, just start the pod.
starting all individual containers make the logic failed
also, we stop all containers first.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#516
How to test this PR?
Stevan's demo
Change-Id: I41ece2faff39b736a5c85f4e675a624df96b3336
Signed-off-by: Florent Benoit fbenoit@redhat.com