chore: refine required attributes instead of requiring full interface #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
dgolovin and
axel7083
and removed request for
a team
it is allowing to reuse that components by providing other objects that have only the required properties part of containers#6083 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
featured-refactor
branch
from
153eac8
to
0d6c67c
Compare
axel7083
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
refactor component to let more usage
no ui change
it is allowing to reuse that components by providing other objects that have only the required properties
Screenshot / video of UI
What issues does this PR fix or reference?
part of #6083
How to test this PR?