Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds downloadable state for extension status widget #6773

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Apr 12, 2024

What does this PR do?

2 commits:

  1. the first one is to fix a copy/paste typo of connection that should be extension
  2. the second one adds downloadable state

Screenshot / video of UI

What issues does this PR fix or reference?

related to #6083

How to test this PR?

  • Tests are covering the bug fix or the new feature

@benoitf benoitf requested a review from a team as a code owner April 12, 2024 14:18
@benoitf benoitf requested review from jeffmaury and lstocchi and removed request for a team April 12, 2024 14:18
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deboer-tim
Copy link
Collaborator

Needs fix for E2E tests, but good to go otherwise.

@benoitf benoitf requested a review from a team as a code owner April 12, 2024 19:53
@benoitf
Copy link
Collaborator Author

benoitf commented Apr 12, 2024

updated, looks like ConnectionStatus component was also used instead of ExtensionStatus component and e2e test just tried to get Connection status as well

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
related to containers#6083
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf merged commit f923e2e into containers:main Apr 12, 2024
8 checks passed
@benoitf benoitf deleted the extension-status-download branch April 12, 2024 20:51
@podman-desktop-bot podman-desktop-bot added this to the 1.10.0 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants