chore: add checks to see if manifest was renamed #6788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
jeffmaury and
lstocchi
and removed request for
a team
cdrage
force-pushed
the
modify-is-manifest
branch
from
10b2f2a
to
bacf386
Compare
jeffmaury
reviewed
Apr 16, 2024
| @@ -39,13 +39,48 @@ const GUESSED_MANIFEST_SIZE = 50 * KB; | |||
| // | |||
| // We will check this within ImageInfo | |||
| export function guessIsManifest(image: ImageInfo, connectionType: string): boolean { | |||
| // There is an odd case that if the image has been renamed, we may not be able to safely detect | |||
There was a problem hiding this comment.
Just wondering why we are not relying on the Names attributes:
C:\Users\Jeff\apps>podman image ls --format json
[
{
"Id": "00339ea1c0d1525fd93fc3aa9c926c75ad2ec32a15627c32bd3924a7dbe667cd",
"ParentId": "",
"RepoTags": null,
"RepoDigests": [
"localhost/mymanifest123@sha256:20b959ad5960230b65a77b746bdbf5d991ade4d7a129c2554e167acdcc990531",
"localhost/mymanifest@sha256:20b959ad5960230b65a77b746bdbf5d991ade4d7a129c2554e167acdcc990531"
],
"Size": 110,
"SharedSize": 0,
"VirtualSize": 110,
"Labels": null,
"Containers": 0,
"Names": [
"localhost/mymanifest123:latest",
"localhost/mymanifest:latest"
],
"Digest": "sha256:20b959ad5960230b65a77b746bdbf5d991ade4d7a129c2554e167acdcc990531",
"History": [
"localhost/mymanifest:latest",
"localhost/mymanifest123:latest"
],
"Created": 1713253600,
"CreatedAt": "2024-04-16T07:46:40Z"
},
There was a problem hiding this comment.
Hi! We do not use names as they can still be changed and do not contain the digest value. We use digests to more accurate detect if it's been renamed or not.
cdrage
force-pushed
the
modify-is-manifest
branch
2 times, most recently
from
11692c7
to
39958a6
Compare
### What does this PR do? * Adds a check to see if a manifest was renamed by analyzing the digests * Adds a test for this as well. ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> N/A ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes containers#6787 ### How to test this PR? <!-- Please explain steps to verify the functionality, do not forget to provide unit/component tests --> - [X] Tests are covering the bug fix or the new feature 1. Create a manifest (it should not appear in PD) 2. Rename the manifest `podman image tag testmanifest testmanifest123` 3. It should **not** appear in PD. Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
force-pushed
the
modify-is-manifest
branch
from
39958a6
to
f1f0ab1
Compare
lstocchi
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: add checks to see if manifest was renamed
What does this PR do?
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Closes #6787
How to test this PR?
podman image tag testmanifest testmanifest123Signed-off-by: Charlie Drage charlie@charliedrage.com