chore(test): add aria labels for rows #6826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Lazar <vlazar@redhat.com>
cbr7
added
area/tests 🚦
kind/enhancement ✨
Signed-off-by: Vladimir Lazar <vlazar@redhat.com>
cbr7
requested review from
dgolovin,
jeffmaury and
a team
and removed request for
a team
odockal
reviewed
Apr 18, 2024
|
FWIW the reason I didn't do this before is that name isn't unique, and there's no guarantee that any new item we decide to put in a table will have a name (although most of them appear to have one now). If the tests don't have situations where there are (e.g.) multiple images with the same name, then it'll be fine for now. |
|
No problem, I just could see possible ambiguity during testing if there are same names used in labels, but that could be workarounded with adding another role/name check. The unit test relying on multiple tooltips seemed awkward to me, that is all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add aria-labels for images and container page rows
What issues does this PR fix or reference?
#5639
How to test this PR?
Check image and container rows to have aria-label property with the corresponding values.