Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add some aria labels to volumes page #6832

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

cbr7
Copy link
Contributor

@cbr7 cbr7 commented Apr 18, 2024

What does this PR do?

Adds some missing area labels to the volumes page

What issues does this PR fix or reference?

#5625

Signed-off-by: Vladimir Lazar <vlazar@redhat.com>
@cbr7 cbr7 linked an issue Apr 18, 2024 that may be closed by this pull request
Signed-off-by: Vladimir Lazar <vlazar@redhat.com>
@cbr7 cbr7 marked this pull request as ready for review April 18, 2024 11:24
@cbr7 cbr7 requested review from benoitf and a team as code owners April 18, 2024 11:24
@cbr7 cbr7 requested review from axel7083, lstocchi and a team and removed request for a team April 18, 2024 11:24
@cbr7 cbr7 merged commit 22a7baf into containers:main Apr 18, 2024
8 checks passed
@cbr7 cbr7 deleted the volume_aria_labels branch April 18, 2024 11:39
Copy link
Contributor

@ScrewTSW ScrewTSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@podman-desktop-bot podman-desktop-bot added this to the 1.10.0 milestone Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide necessary ARIA functionality in Volumes (Volumes Details Page)
4 participants