chore: include extension version in telemetry #6858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loadExtension and activateExtension telemetry events include the ids of extensions but not the versions. It would be handy if we have them here both for general debugging/fleet understanding, but also to stop each new extension from wanting to add a startup event. Extensions should not get to either path without a valid manifest + version, just being slightly paranoid and consistent with prior code using ?. There was no basic loadExtension test so I started one; also updated the activateExtension test to check for telemetry. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
cdrage and
feloy
and removed request for
a team
benoitf
approved these changes
Apr 22, 2024
axel7083
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The loadExtension and activateExtension telemetry events include the ids of extensions but not the versions. It would be handy if we have them here both for general debugging/fleet understanding, but also to stop each new extension from wanting to add a startup event.
Extensions should not get to either path without a valid manifest + version, just being slightly paranoid and consistent with prior code using ?.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #6857.
How to test this PR?
There was no basic loadExtension test so I started one; also updated the activateExtension test to check for telemetry.