fix: createContainer using Podman API should be a different method on API endpoint #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… API endpoint Else it is replacing the compat API code fixes containers#691 Change-Id: I7210567ae88826bc969f1f12007f6c740b65995d Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
createContainer API was overrided with libPod API leading to a different return value.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#691
How to test this PR?
Try to install a desktop extension
Change-Id: I7210567ae88826bc969f1f12007f6c740b65995d
Signed-off-by: Florent Benoit fbenoit@redhat.com