chore(tests): update extensions tests, pom and related functionality #6931
Conversation
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
odockal
requested review from
dgolovin and
cdrage
and removed request for
a team
| @@ -18,10 +18,10 @@ | |||
|
|
|||
| import type { Page } from '@playwright/test'; | |||
|
|
|||
| import { ExtensionPage } from './extension-page'; | |||
| import { ExtensionDetailsPage } from './extension-details-page'; | |||
There was a problem hiding this comment.
why do we have this class in this repository ? AFAIK it should be in its own repository
There was a problem hiding this comment.
This is here for some time already.
Was also an option to have them in their particular repos, altough, if you want to test multiple external resources, you would need to share POM. Ideally on once place and this repo seems like logical place.
There was a problem hiding this comment.
it should not be there at all. Podman Desktop has no knowledge on 3rd party extension
you may have different model page for each version of the extension so it can't be there
There was a problem hiding this comment.
if you want to test multiple external resources, you would need to share POM
I don't get it there ? Nothing related to external extension should be there, only the things concerning the pages provided by Podman Desktop
There was a problem hiding this comment.
Well this is a change from the previous agreement as I understood it, previously it was discussed that extension tests should be in the extension repos, but that the framework part could be here so that we can use it in other tests also.
For example if we move the framework part in their respective extension repos it will be much harder to create an e2e test that could test other features that might also imply some functionality from an extension, like for example if you wanted an e2e test that would use functionality from AI Lab and bootc in one test.
| return new ExtensionDetailsPage(this.page, this.extensionName); | ||
| } | ||
|
|
||
| async disableExtension(): Promise<this> { |
There was a problem hiding this comment.
Aren't these methods already exposed from extension-details-page.ts?
There was a problem hiding this comment.
Extensions Details page and Extensions/ExtensionsCard Page are two distinguished pages with the same locators.
There was a problem hiding this comment.
I mean yes, but if the functionality is identical it suggests that some kind of abstract class that both page object inherit should be used, there is no reason to have two different POM models implement literally identical functionalities.
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
|
@benoitf I have noticed failing podman-extension tests. Fixed that by the latest commit. |
|
FYI there is a typo in the last commit
|
Uf, nice, glad it is variable name. |
What does this PR do?
update extensions tests and pom to align with new Extensions pages.
Screenshot / video of UI
What issues does this PR fix or reference?
#6894
How to test this PR?
yarn test:e2e:extension