feat(RecommendationsRegistry): uses deterministic method to choose which banner is displayed #6947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In todays implementation we are using a random system to determine which banner will be displayed.
podman-desktop/packages/main/src/plugin/recommendations/recommendations-registry.ts
Line 74 in 662a07f
This has a serious drawback, each call a different one could be returned, leading to ui flickering, since the extension banner store is subscribed to specific events (required) it get re-render a little bit too often
podman-desktop/packages/renderer/src/stores/extensionBanners.ts
Lines 24 to 32 in 74923cc
To avoid this flickering, we need to have the same result for a period of time, here we choose by the hours.
Screenshot / video of UI
What issues does this PR fix or reference?
Fixes #6941
How to test this PR?