Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ExtensionBanner): adding lab extension to recommendation #6951

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Apr 25, 2024

What does this PR do?

Screenshot / video of UI

See https://github.com/containers/podman-desktop-internal/issues/243#issuecomment-2076657881

What issues does this PR fix or reference?

Fixes https://github.com/containers/podman-desktop-internal/issues/243

How to test this PR?

How to test ?

Change the property publishDate in the recommendations.json file for the extension that you want to see.

We can only see one, so put some very far date for the extension you want to hide.

  • Tests are covering the bug fix or the new feature

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested review from benoitf and a team as code owners April 25, 2024 11:58
@axel7083 axel7083 requested review from dgolovin and feloy and removed request for a team April 25, 2024 11:58
featured.json Outdated Show resolved Hide resolved
recommendations.json Outdated Show resolved Hide resolved
featured.json Outdated Show resolved Hide resolved
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
recommendations.json Outdated Show resolved Hide resolved
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
recommendations.json Outdated Show resolved Hide resolved
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf benoitf merged commit ce55486 into containers:main Apr 25, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.10.0 milestone Apr 25, 2024
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants