-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ExtensionBanner): adding lab extension to recommendation #6951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
requested review from
dgolovin and
feloy
and removed request for
a team
April 25, 2024 11:58
benoitf
reviewed
Apr 25, 2024
benoitf
reviewed
Apr 25, 2024
Co-authored-by: Florent BENOIT <fbenoit@redhat.com> Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
benoitf
approved these changes
Apr 25, 2024
axel7083
commented
Apr 25, 2024
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
commented
Apr 25, 2024
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
jeffmaury
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Screenshot / video of UI
See https://github.com/containers/podman-desktop-internal/issues/243#issuecomment-2076657881
What issues does this PR fix or reference?
Fixes https://github.com/containers/podman-desktop-internal/issues/243
How to test this PR?
How to test ?
Change the property
publishDate
in therecommendations.json
file for the extension that you want to see.