Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle starting as mode where stop should be visible #6957

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Apr 25, 2024

What does this PR do?

extension is going from stopped to starting to started and we should display stop in starting state as the start button will disappear as soon as stopped condition is gone, so during the starting phase there is nothing which might cause some blinking

Screenshot / video of UI

What issues does this PR fix or reference?

How to test this PR?

  • Tests are covering the bug fix or the new feature

might be related to containers#6863
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner April 25, 2024 13:26
@benoitf benoitf requested review from jeffmaury and cdrage and removed request for a team April 25, 2024 13:26
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf benoitf merged commit 141210f into containers:main Apr 25, 2024
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.10.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants