fix: add suggestion when WSL seems to require a reboot #7007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lstocchi <lstocchi@redhat.com>
|
cc @odockal |
benoitf
approved these changes
Apr 29, 2024
|
Gonna take a look. Thx! |
|
LGTM. Tried on Windows. User is now guided to finish the system preparation. |
odockal
approved these changes
Apr 30, 2024
benoitf
pushed a commit
to benoitf/desktop
that referenced
this pull request
Apr 30, 2024
Signed-off-by: lstocchi <lstocchi@redhat.com>
1 task
benoitf
pushed a commit
to benoitf/desktop
that referenced
this pull request
Apr 30, 2024
Signed-off-by: lstocchi <lstocchi@redhat.com> Signed-off-by: Florent Benoit <fbenoit@redhat.com> Signed-off-by: Luca Stocchi <49404737+lstocchi@users.noreply.github.com>
benoitf
pushed a commit
that referenced
this pull request
Apr 30, 2024
Signed-off-by: lstocchi <lstocchi@redhat.com> Signed-off-by: Florent Benoit <fbenoit@redhat.com> Signed-off-by: Luca Stocchi <49404737+lstocchi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
it adds a suggestion to try installing wsl without any distribution if after having installed virtual platform and wsl and have rebooted the machine, there are still sign the machine needs to be rebooted.
Screenshot / video of UI
What issues does this PR fix or reference?
it fixes #6978
How to test this PR?