fix: the Image.Id should contain sha256: prefix when listing image Id #7009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be compliant with compat API image needs to be prefixed fixes containers#6974 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
dgolovin and
lstocchi
and removed request for
a team
Screen.Recording.2024-04-29.at.3.06.37.PM.movSo I checked this pretty thoroughly against an extension that uses image inspect, etc and it worked completely fine. Had no issues doing multi-arch builds (it showed up in Thanks for noticing we need sha256 here! LGTM! |
cdrage
approved these changes
Apr 29, 2024
deboer-tim
approved these changes
Apr 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To be compliant with compat API, the image Id needs to be prefixed (with podman it's not prefixed)
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #6974
How to test this PR?