Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Update font size of navbar #701

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Oct 26, 2022

Update font size of navbar website

What does this PR do?

This updates the navbar up at the top to a smaller font as it's not
visually appealing on smaller screens / looks odd.

Screenshot/screencast of this PR

Before:

Screen Shot 2022-10-26 at 10 20 04 AM

After:

Screen Shot 2022-10-26 at 10 20 29 AM

What issues does this PR fix or reference?

N/A

How to test this PR?

View the site :)

Signed-off-by: Charlie Drage charlie@charliedrage.com

@benoitf
Copy link
Collaborator

benoitf commented Oct 26, 2022

adding @mairin as reviewer

@benoitf benoitf changed the title Update font size of navbar website website: Update font size of navbar website Oct 26, 2022
@benoitf benoitf changed the title website: Update font size of navbar website website: Update font size of navbar Oct 26, 2022
@mairin
Copy link
Member

mairin commented Oct 26, 2022

Hi @cdrage! Could you potentially add a @media query to have this font size kick in when the "podman desktop" starts getting ellipsized? This is a good fix for that issue, but for 4k monitors i think the bigger text is preferable for readability. (What do you think?)

@cdrage
Copy link
Contributor Author

cdrage commented Oct 27, 2022

Hi @cdrage! Could you potentially add a @media query to have this font size kick in when the "podman desktop" starts getting ellipsized? This is a good fix for that issue, but for 4k monitors i think the bigger text is preferable for readability. (What do you think?)

I was under the impression that em scales with resolution. I'm unsure how to implement using @media with tailwindcss.

What were you thinking, maybe if a screen is detected higher than 1920x width than use the original em?

@benoitf
Copy link
Collaborator

benoitf commented Oct 27, 2022

something like

.navbar__title {
  font-size: 1.2em;
  font-weight: 500;
  padding-right: 0.5em;
}


.navbar__logo img {
  padding-right: 7px;
}

.navbar__logo {
  min-height: 56px;
}


@media (min-width: 1200px) {
  .navbar__title {
    font-size: 2em;
    padding-right: 1em;
  }

  .navbar__item {
    font-size: 1.2em;
  }
   
}

@cdrage
Copy link
Contributor Author

cdrage commented Oct 27, 2022

Updated!

website/src/css/custom.css Outdated Show resolved Hide resolved
@cdrage
Copy link
Contributor Author

cdrage commented Oct 27, 2022

Had to re-sign the commit, so I've updated the PR :)

### What does this PR do?

This updates the navbar up at the top to a smaller font as it's not
visually appealing on smaller screens / looks odd.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

N/A

### How to test this PR?

<!-- Please explain steps to reproduce -->

View the site :)

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@benoitf benoitf merged commit cd84e93 into containers:main Oct 27, 2022
@podman-desktop-bot podman-desktop-bot added this to the 0.10.0 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants