chore: display additional field if installed version is different #7025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
dgolovin and
lstocchi
and removed request for
a team
1 task
deboer-tim
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Confirmed that I can now see the difference between an old installed extension and a newer one in the catalog.
The catalog details page still lists the local version, and if auto-update is disabled I have to delete the local copy to be able to update to the catalog version, but +1 since this is an improvement and now correct. We can track remaining issues for 1.11+ separately.
|
Works for me with a newer installed version than the catalog version. Is it expected to have a different color for the installed version (gray-500) compared to the catalog version (gray-700)? |
|
@feloy no, I will revert |
fixes containers#6989 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
@feloy fixed |
feloy
approved these changes
Apr 30, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Display installed version if different than the catalog version
for example if I have a different version than the one in the catalog I should be able to see if while seeing the catalog because if I click on the details I will the version of the installed extension
Screenshot / video of UI
What issues does this PR fix or reference?
fixes #6989
How to test this PR?