-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show manifests in image list #7227
Conversation
9c9e970
to
9140cd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's curious/annoying that manifests are images in the API, and makes it so that something like ImageColumnActions needs to be shared. :-/
I think this is a good place to go with the first PR, but:
- In the containers view we have "my-pod (pod)", but here you used a badge. We obviously didn't have badges when we did the containers view, but I think we need to decide with design the right way to identify 'different things in a table' is and make them consistent. For simplicity/consistency maybe I'd rather use '(manifest)' until we know.
- The icon should be different from a regular image.
- Manifests should have details pages (but can be a separate issue).
- We should allow them to expand/collapse with the images that are in them, but that is post Table component support for parent/children #7209.
I don't want to hold this up too much, but I think we should at least have a direction on 1/2 and issue for 3 before we merge.
I totally agree, let's talk about it in the UX call. There are a lot of other missing pieces that should be worked on before we merge the "showing in list" support. For this PR I will:
I thought I had opened a "details" issue for manifest, but I had not. I've opened up issue #7255 and added it to the epic #6526 Maybe we should keep this as draft / WIP until we get the details page in too so we at least have the basic functionality of manifests. |
7457715
to
e2aaadb
Compare
This PR is ready for review with the exception of the new icon being added, which can be in a follow up PR. I've made the following changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as described. LGTM
849c23d
to
3e1dd3d
Compare
### What does this PR do? * Shows manifest in the image list * Does NOT show any actions / be able to click (yet) * SHows "manifest" as a badge. ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes containers#6529 ### How to test this PR? <!-- Please explain steps to verify the functionality, do not forget to provide unit/component tests --> - [X] Tests are covering the bug fix or the new feature 1. Create a manifest through the GUI or `podman build --platform linux/arm64,linux/amd64 --manifest testmanifest123` 2. View the manifest in image list. Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Manifest icon has now been added and this PR is ready for another review @lstocchi @deboer-tim |
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, worked well in testing.
feat: show manifests in image list
What does this PR do?
Screenshot / video of UI
Screen.Recording.2024-05-21.at.11.06.01.AM.mov
What issues does this PR fix or reference?
Closes #6529
Closes #7255
How to test this PR?
podman build --platform linux/arm64,linux/amd64 --manifest testmanifest123
Signed-off-by: Charlie Drage charlie@charliedrage.com