fix: provide registry config when building images #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes containers#722 Change-Id: I96bc075409b0639d94c47fed1731d658f2208202 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
cdrage
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add missing auth details for registries when building images.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
fixes #722
How to test this PR?
Build a containerfile that uses a private image from a registry (and you are authenticated on this registry)
Change-Id: I96bc075409b0639d94c47fed1731d658f2208202
Signed-off-by: Florent Benoit fbenoit@redhat.com