Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build arguments to build page #7253

Merged
merged 1 commit into from
May 27, 2024

Commits on May 22, 2024

  1. feat: add build arguments to build page

    ### What does this PR do?
    
    Build arguments is already built-in to podman desktop API.
    
    This adds to the UI the ability to pass in build arguments.
    
    ### Screenshot / video of UI
    
    <!-- If this PR is changing UI, please include
    screenshots or screencasts showing the difference -->
    
    ### What issues does this PR fix or reference?
    
    <!-- Include any related issues from Podman Desktop
    repository (or from another issue tracker). -->
    
    Closes containers#7250
    
    ### How to test this PR?
    
    <!-- Please explain steps to verify the functionality,
    do not forget to provide unit/component tests -->
    
    - [X] Tests are covering the bug fix or the new feature
    
    1. Build a Containerfile with ARG
    2. See it fail (normal)
    3. In build args, add your arg (ex. foo=bar)
    4. It will now build and pass.
    
    Signed-off-by: Charlie Drage <charlie@charliedrage.com>
    cdrage committed May 22, 2024
    Configuration menu
    Copy the full SHA
    65dfabf View commit details
    Browse the repository at this point in the history