fix: do not display volume badge if it's zero #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes containers#726 Change-Id: I05627f95e075543b07b1d7cedbcb19321217d14c Signed-off-by: Florent Benoit <fbenoit@redhat.com>
cdrage
approved these changes
Oct 28, 2022
|
Thanks for the quick fix! That was extraordinarily quick 🚀 |
slemeur
pushed a commit
to deekay2310/podman-desktop
that referenced
this pull request
Nov 2, 2022
fixes containers#726 Change-Id: I05627f95e075543b07b1d7cedbcb19321217d14c Signed-off-by: Florent Benoit <fbenoit@redhat.com> Signed-off-by: Florent Benoit <fbenoit@redhat.com> Signed-off-by: Stévan Le Meur <1636769+slemeur@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensure we don't display the badge for volumes if there are no volumes
Screenshot/screencast of this PR
n6dvNplqTO.mp4
What issues does this PR fix or reference?
fixes #726
How to test this PR?
Check badge is gone after deleting all volumes
Change-Id: I05627f95e075543b07b1d7cedbcb19321217d14c
Signed-off-by: Florent Benoit fbenoit@redhat.com