Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Add info about package managers for Windows #736

Merged
merged 1 commit into from Oct 30, 2022

Conversation

rsvoboda
Copy link
Contributor

Info about package managers for Windows

Fixes #733

CC @benoitf

Screenshot 2022-10-29 at 21 56 36

Fixes containers#733

Signed-off-by: Rostislav Svoboda <rsvoboda@redhat.com>
@benoitf
Copy link
Collaborator

benoitf commented Oct 29, 2022

awesome. Thanks for the PR

@benoitf benoitf changed the title Info about package managers for Windows website: Add info about package managers for Windows Oct 29, 2022
@rsvoboda
Copy link
Contributor Author

I will amend my commit message to reflect https://github.com/containers/podman-desktop/blob/main/CONTRIBUTING.md#use-the-correct-commit-message-semantics

Should I use style: or something else (e.g. website:)?

@benoitf
Copy link
Collaborator

benoitf commented Oct 29, 2022

it's ok. Only PR title needs conventional commits

@benoitf
Copy link
Collaborator

benoitf commented Oct 29, 2022

website: prefix is used for the website. I should amend the readme file

@rsvoboda
Copy link
Contributor Author

ok, I won't touch the commit message. I did update them for #737 though :)

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rsvoboda for your contribution 🎉

image

image

image

@benoitf benoitf merged commit 6fc7b49 into containers:main Oct 30, 2022
@podman-desktop-bot podman-desktop-bot added this to the 0.10.0 milestone Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance download page with info about package managers for Windows
3 participants