chore: manifest icon #7366
Merged
chore: manifest icon #7366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the manifest icon required for containers#6529. Part of containers#6529. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
feloy and
ekidneyrh
and removed request for
a team
Closed
cdrage
approved these changes
May 29, 2024
|
The icons seem reversed here. Isn't the filled icon meant to be used when the status is USED and the lined one when it's UNUSED?
|
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this pull request
May 30, 2024
While testing containers#7366 I swapped the solid/non-solid versions of the manifest icon, and forgot to swap it back. On the plus side, I'm now a sure win for smallest fix of the sprint! Signed-off-by: Tim deBoer <git@tdeboer.ca>
Yes, my bad. Fix up for review in #7377. |
cdrage
pushed a commit
that referenced
this pull request
May 30, 2024
While testing #7366 I swapped the solid/non-solid versions of the manifest icon, and forgot to swap it back. On the plus side, I'm now a sure win for smallest fix of the sprint! Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage
added a commit
to cdrage/podman-desktop
that referenced
this pull request
May 30, 2024
Adds the manifest icon required for containers#6529. Part of containers#6529. Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage
added a commit
to cdrage/podman-desktop
that referenced
this pull request
May 30, 2024
Adds the manifest icon required for containers#6529. Part of containers#6529. Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage
added a commit
to cdrage/podman-desktop
that referenced
this pull request
May 30, 2024
Adds the manifest icon required for containers#6529. Part of containers#6529. Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage
added a commit
to cdrage/podman-desktop
that referenced
this pull request
May 30, 2024
Adds the manifest icon required for containers#6529. Part of containers#6529. Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage
pushed a commit
to cdrage/podman-desktop
that referenced
this pull request
Jun 19, 2024
Adds the manifest icon required for containers#6529. Part of containers#6529. Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage
pushed a commit
to cdrage/podman-desktop
that referenced
this pull request
Jun 19, 2024
While testing containers#7366 I swapped the solid/non-solid versions of the manifest icon, and forgot to swap it back. On the plus side, I'm now a sure win for smallest fix of the sprint! Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the manifest icon required for #6529.
Screenshot / video of UI
What issues does this PR fix or reference?
Part of #6529.
How to test this PR?
Replace one of the icons in another list with ManifestIcon.