fix: reduce telemetry events on listXXX events #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is sent only after 24h from previous event if user is keeping running the tool Change-Id: Id17b2131abcae17a5c9262240d0910c2ddca63c1 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
Unsure how to troubleshoot telemetry PR's, but does this LGTM @slemeur ? |
|
Instead of not sending the event - could we:
|
|
@slemeur I'm not sure it's useful |
IMOH It doesn't make any sense. If you're not pulling/running containers, we would send the same event than before
list events are not triggered directly using user action (for example starting a new container is asking to list again the containers) If you need something every 24h then it should be another report/event |
|
We should proceed with this proposition. |
cdrage
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It is sent only after 24h from previous event if user is keeping running the tool
if you restart it will send the event again
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes #658
How to test this PR?
Use a proxy and monitor telemetry events being sent
Change-Id: Id17b2131abcae17a5c9262240d0910c2ddca63c1
Signed-off-by: Florent Benoit fbenoit@redhat.com