fix: on Linux, wait at max for 5s if socket is made available #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes containers#656 Change-Id: I400f0e1c3d8466daf4ed1d788ea580fe768ae0c1 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
cdrage
approved these changes
Nov 7, 2022
|
Approved + was able to test it out and seems to work well within a slow VM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace the wait for half of a second by a longer delay and a shorter wait if the socket file is already there
note: this is only for Linux.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
fixes #656
How to test this PR?
On Linux, with a probably slower i/o disk (I was not able to reproduce the issue)
Launch Podman Desktop and see if if says that Podman is there
Change-Id: I400f0e1c3d8466daf4ed1d788ea580fe768ae0c1
Signed-off-by: Florent Benoit fbenoit@redhat.com