Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Dependency update to vite v3 #785

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Nov 7, 2022

What does this PR do?

Upgrade from vite 2 to vite 3

  • It requires to flag chokidar as an external dependency
  • it requires to add more memory to Node.js

https://vitejs.dev/guide/migration.html#config-options-changes

Screenshot/screencast of this PR

No screenshot, it's happening under the hood :-)

What issues does this PR fix or reference?

Keep dependencies up-to-date to avoid security issues, etc.

How to test this PR?

Try in development mode and then in production mode (yarn compile:current and try out binary produced)

Change-Id: I5cc526aa2e0885eb265d441cf6531b5cb594d093
Signed-off-by: Florent Benoit fbenoit@redhat.com

Change-Id: I5cc526aa2e0885eb265d441cf6531b5cb594d093
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf marked this pull request as ready for review November 7, 2022 11:24
@benoitf benoitf changed the title chore: Dependency update to vite 3 chore: Dependency update to vite v3 Nov 7, 2022
@cdrage cdrage merged commit 6cc28e1 into containers:main Nov 7, 2022
@podman-desktop-bot podman-desktop-bot added this to the 0.10.0 milestone Nov 7, 2022
@benoitf benoitf self-assigned this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants