Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable all tests #858

Merged
merged 1 commit into from
Dec 1, 2022
Merged

chore: enable all tests #858

merged 1 commit into from
Dec 1, 2022

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Nov 18, 2022

What does this PR do?

Launch all tests, not only the one from main package

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A

How to test this PR?

Check if Github Action PR check is green

Change-Id: Id51f7e12f26ce11d8a2b4cfa2d28ec2f3028ca73
Signed-off-by: Florent Benoit fbenoit@redhat.com

@benoitf benoitf marked this pull request as draft November 18, 2022 08:06
@benoitf benoitf force-pushed the all-unit-tests branch 2 times, most recently from 0d7dcd9 to ec88317 Compare November 28, 2022 10:23
@benoitf benoitf marked this pull request as ready for review November 28, 2022 10:47
@benoitf benoitf marked this pull request as draft November 28, 2022 10:48
@benoitf benoitf marked this pull request as ready for review November 28, 2022 10:53
@cdrage
Copy link
Contributor

cdrage commented Nov 30, 2022

There is a merge conflict with package.json

But otherwise, this LGTM!

Tested it locally and it worked (well, I forgot to run yarn install before-hand for xvfb-maybe, but it worked after that!)

yarn test passes.

@benoitf
Copy link
Collaborator Author

benoitf commented Nov 30, 2022

will fix the merge conflict, I think it's because the PR is there since too long

Change-Id: Id51f7e12f26ce11d8a2b4cfa2d28ec2f3028ca73
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf enabled auto-merge (rebase) December 1, 2022 07:14
@benoitf benoitf merged commit 1cbb5d3 into containers:main Dec 1, 2022
@podman-desktop-bot podman-desktop-bot added this to the 0.10.0 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants