Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle properly certificates on Windows #920

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Nov 28, 2022

What does this PR do?

  • Use alternative path for win-ca root.exe (as it may not be possible to read root.exe from .asar archive)
  • Use a try/catch block for Windows certificates (in case of unknown error)

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A

How to test this PR?

Launch on Windows and see if no error is reported when starting the application

Change-Id: I8fa6540afcd0aea1e1d548c7052a4372a685bd36
Signed-off-by: Florent Benoit fbenoit@redhat.com

@benoitf benoitf marked this pull request as ready for review November 28, 2022 15:05
@benoitf benoitf marked this pull request as draft November 28, 2022 15:05
@benoitf benoitf marked this pull request as ready for review November 28, 2022 15:41
@benoitf benoitf force-pushed the handle-error-cert branch 2 times, most recently from 2621699 to 565d067 Compare November 28, 2022 16:58
@benoitf benoitf marked this pull request as draft November 28, 2022 16:58
Use alternate path for win-ca root.exe in production
And try/catch certificates retrieval

Change-Id: I8fa6540afcd0aea1e1d548c7052a4372a685bd36
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf marked this pull request as ready for review November 28, 2022 18:01
@benoitf benoitf changed the title fix: handle properly error if on Windows we can't read certificates fix: handle properly certificates on Windows Nov 28, 2022
@benoitf benoitf merged commit c9ad8d0 into containers:main Nov 29, 2022
@podman-desktop-bot podman-desktop-bot added this to the 0.10.0 milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants