Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fails when unable to find podman assets #931

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Nov 29, 2022

What does this PR do?

  • fails when unable to find podman assets
  • apply trim to make it more robust

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Fixes #928

How to test this PR?

yarn build in extensions/podman folder.
(remove assets folder of extensions/podman first)

Change-Id: I8a23bb4ead274c69c8e719ae17822e63988eaaa8
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
fixes containers#928

Change-Id: Icf669a31ad0812e5de561e323d618d6ab571938c
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@cdrage
Copy link
Contributor

cdrage commented Nov 30, 2022

LGTM! Merge when you're ready 👍

@benoitf benoitf merged commit ff4c894 into containers:main Nov 30, 2022
@podman-desktop-bot podman-desktop-bot added this to the 0.10.0 milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failing to download a binary when assembling the release should fail the process
3 participants