Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move extension properties to preferences #948

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Dec 1, 2022

What does this PR do?

Make preferences visible (and only the one with the default scope) when adding simple properties to an extension.

Screenshot/screencast of this PR

image

What issues does this PR fix or reference?

#947

How to test this PR?

Add some properties (like in podman package.json file)

      "properties": {
        "podman.my.test.property": {
          "type": "string",
          "default": "test",
          "description": "My test property"
        },

and look if you see them appear in the preferences screen.

Change-Id: If8889eae5c1ef13232d22fe2539b941b728e2fef
Signed-off-by: Florent Benoit fbenoit@redhat.com

Change-Id: If8889eae5c1ef13232d22fe2539b941b728e2fef
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants