fix: wsl2 detection #981
Merged
fix: wsl2 detection #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
benoitf
reviewed
Dec 6, 2022
Co-authored-by: Florent BENOIT <fbenoit@redhat.com> Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
|
it's not an issue to set WSL to 2 as a check if the user is using WSL1 (and do not want to set WSL2) or it'll just call a prompt ? |
|
Hmm, that is good point. So even if we don’t use switching to wsl2, podman CLI will do. |
|
|
benoitf
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It change the way of WSL2, as suggested in #857 (comment) I try to use
wsl --set-default-version 2as command which ensures that user has wsl2 installed and it has permission to use it.Screenshot/screencast of this PR
n/a
What issues does this PR fix or reference?
resolve #857
How to test this PR?